Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update bouquet card component on listing #599

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

at-github
Copy link
Contributor

@@ -141,4 +141,8 @@ const { themeColors } = useThemeOptions(theme)
display: block;
line-height: inherit;
}

.bouquet-card-col-logo {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas satisfait de cette astuce mais je n'ai pas réussi à avoir la même largeur de colonne juste avec le système de grille. Preneur d'une suggestion

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit aacd34d
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/67473480965100000802a9bb
😎 Deploy Preview https://deploy-preview-599--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit aacd34d
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/674734806999d10008efa6f4
😎 Deploy Preview https://deploy-preview-599--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas mal de différences par rapport à la maquette :

  • Il manque la description du bouquet dans la carte de la page de liste.
  • Le logo fait 56px (plus petit)
  • Manque majuscule à "Mise à jour"
  • Le gris de "Mise à jour" n'est pas celui de la maquette
  • La graisse des tags (pastilles) n'est pas la même
Capture d’écran 2024-11-25 à 10 23 59 Capture d’écran 2024-11-25 à 10 33 22

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça m'a l'air bon à part le petit commentaire. Je laisse @narduin valider pour les histoires de styles 💅.

src/assets/main.css Outdated Show resolved Hide resolved
@at-github at-github force-pushed the feat/update-bouquet-card-component-on-listing branch from 737d82f to aa4c071 Compare November 26, 2024 09:01
@@ -44,49 +46,47 @@ const { themeColors } = useThemeOptions(theme)
</script>

<template>
<article class="fr-my-3w fr-p-3w border border-default-grey fr-enlarge-link">
<article
class="fr-my-1w fr-px-3w fr-py-2w border border-default-grey fr-enlarge-link"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24px partout sur la maquette

Suggested change
class="fr-my-1w fr-px-3w fr-py-2w border border-default-grey fr-enlarge-link"
class="fr-my-1w fr-p-3w border border-default-grey fr-enlarge-link"

J'avais pas fait attention que ça restait pareil en mobile… Ça me semble être beaucoup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avec ce résultat j'ai un espacement plus grand en haut que sur les côtés, ce qui ne fait pas trop harmonieux. C'est, il me semble, plus agréable quand on distingue une carré d'espacement dans les angles

src/components/bouquets/BouquetCard.vue Outdated Show resolved Hide resolved
src/components/bouquets/BouquetCard.vue Outdated Show resolved Hide resolved
src/custom/ecospheres/views/HomeView.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mettre à jour les cards bouquets dans le listing
3 participants