-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update bouquet card component on listing #599
base: main
Are you sure you want to change the base?
Conversation
@@ -141,4 +141,8 @@ const { themeColors } = useThemeOptions(theme) | |||
display: block; | |||
line-height: inherit; | |||
} | |||
|
|||
.bouquet-card-col-logo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas satisfait de cette astuce mais je n'ai pas réussi à avoir la même largeur de colonne juste avec le système de grille. Preneur d'une suggestion
✅ Deploy Preview for ecospheres ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for meteo-france ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça m'a l'air bon à part le petit commentaire. Je laisse @narduin valider pour les histoires de styles 💅.
737d82f
to
aa4c071
Compare
@@ -44,49 +46,47 @@ const { themeColors } = useThemeOptions(theme) | |||
</script> | |||
|
|||
<template> | |||
<article class="fr-my-3w fr-p-3w border border-default-grey fr-enlarge-link"> | |||
<article | |||
class="fr-my-1w fr-px-3w fr-py-2w border border-default-grey fr-enlarge-link" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24px partout sur la maquette
class="fr-my-1w fr-px-3w fr-py-2w border border-default-grey fr-enlarge-link" | |
class="fr-my-1w fr-p-3w border border-default-grey fr-enlarge-link" |
J'avais pas fait attention que ça restait pareil en mobile… Ça me semble être beaucoup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avec ce résultat j'ai un espacement plus grand en haut que sur les côtés, ce qui ne fait pas trop harmonieux. C'est, il me semble, plus agréable quand on distingue une carré d'espacement dans les angles
Fix : ecolabdata/ecospheres#409